Conversation
Contributor
|
✅ KSAI Review: Finished
Run report (federated) · 1 paid run · $0.0353 total
Reviewing cost $0.0352; deciding how to run it cost $0.0001 |
Contributor
There was a problem hiding this comment.
| Check | Result |
|---|---|
| Scope | Two new declarative overlays and E2E scenario steps 013-016 covering a decrypt_fields child consume policy (create, verify, idempotency, sync-delete) |
| Mandate | default-code-reviewer |
| Findings | 2 Low |
| Findings audit | Completed |
The new steps match proven patterns in this scenario: delete plans key on resource name, nested empty lists signal sync deletes, and static-key plaintext drift does not break idempotency re-plans. No additional concerns found in the secrets, security, or leak dimensions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The consume-policy E2E scenario did not exercise
decrypt_fields.Add a schema-validation parent and static key, then verify field-level
decryption creation, the exact parent link and returned config, no-op
replanning, sync deletion, and prerequisite cleanup.
Use Konnect's canonical bracket notation for the field path so the fixture
round-trips without normalization drift.
Closes #2168.
Validation:
--allow-serial-runnersto wait for anotherlocal lint process).
make test-e2e-scenarios SCENARIO=event-gateway/consume-policypassed./home/rspurgeon/go/e2e-artifacts/20260915-225157.