Conversation
Contributor
|
✅ KSAI Review: Finished
Run report (federated) · 1 paid run · $0.0105 total
Reviewing cost $0.0104; deciding how to run it cost $0.0001 |
![kong-api-ops[bot]](https://avatars.githubusercontent.com/b/232061?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
| Check | Result |
|---|---|
| Scope | Two refactor hunks: Konnect vault matching in internal/declarative/resources/ai_gateway_vault.go and persistent flag registration in internal/extensions/persistent_flags.go |
| Mandate | go-code-reviewer (adversarial Go, diff focus) |
| Findings | 1 Low |
| Findings audit | Completed |
Both hunks are behavior-preserving: truth-table comparison of old and new TryMatchKonnectResource logic matches on all inputs, and the hoisted flag set is identical across calls. No additional concerns found in the secrets, security, or leak passes.
rspurgeon
had a problem deploying
to
kongctl-acceptance
September 16, 2026 04:20 — with 
GitHub Actions
Failure
GitHub Actions
Failure
This was referenced Sep 16, 2026
rspurgeon
requested a deployment
to
kongctl-acceptance
September 16, 2026 16:20 — with
GitHub Actions
In progress
GitHub Actions
In progress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI Gateway vault matching repeats an ID extraction that marshals the same
resource to JSON. Compute the ID once and return early when it is empty,
while preserving ID-first matching and the name fallback. Reuse a local
persistent flag set when registering extension flags.
Behavior and tests are unchanged.
Validation:
CGO_ENABLED=0 go fix ./...,make format(no changes),make build, andmake test-all(lint, installer, unit, E2E metrics,and integration tests).
Closes #2191.