refactor(declarative): register ordered collection validation - #2197
Merged
Merged
Conversation
31 tasks
Contributor
|
✅ KSAI Review: Finished
Run report (federated) · 1 paid run · $0.0452 total
Reviewing cost $0.0449; deciding how to run it cost $0.0003 |
Contributor
There was a problem hiding this comment.
| Check | Result |
|---|---|
| Scope | 21 files: registry-driven collection-validation dispatch replacing per-type loader validation in internal/declarative |
| Mandate | go-code-reviewer (adversarial) |
| Findings | 1 Medium, 2 Low |
| Findings audit | Completed |
The phase table reproduces the removed hardcoded validation sequence exactly, including gateway-service/audit-log/certificate interleaving. The gaps are untested ordering and guards, plus one latent guard-ordering inconsistency. No additional concerns found: no secrets, no security surface, no resource leaks.
rspurgeon
had a problem deploying
to
kongctl-acceptance-3
September 16, 2026 14:53 — with
GitHub Actions
Failure
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a collection validator required separate edits to resource registration
and loader dispatch. This change registers the existing root validators and
derives the complete ordered collection pass from resource and selector
capabilities, so registration also supplies invocation.
validation; share type-wide name checks across seven roots while preserving
namespace-specific, external, duplicate-ref, and nested API rules.
→ certificates, API-before-Portal child validation, and organization selector
ordering. Keep normalization, cross-references, and namespaces in the loader.
typed registrations, missing inherited/selector phases, and duplicate
positions. Explicit child phases work without a family default.
Retain explicit Event Gateway validation omissions and the three loader
methods called directly by existing tests.
sequence, assemble actual registrations directly, exercise rejection guards,
and cover explicit phases without a family default.
contract test, and remaining boundaries.
Validation: baseline and final candidate
make test-all(lint, installerchecks, race-enabled unit/integration suites, and 99 E2E tooling tests);
read-only
go fix -diff ./...; formatting with existing struct tags preserved;and CGO-disabled
make build-ci.External production overlays compare 2,270 cases, each validated twice:
dispatch traces, errors, and serialized resource state match main. Nine
deliberate misregistrations trigger the expected guards. The new tests also
detect a deliberate phase permutation and removal of four dispatch/registration
guards; the explicit-phase regression test fails against the previous code.
This is bounded compatibility evidence, not exhaustive API coverage.
All 1,650 existing test/fixture files remain unchanged.
Refs #2079. This completes the ordered collection-validation milestone;
cross-pipeline capability completeness remains follow-up work.