Skip to content

Use EvenMoreFish API - #883

Merged
Krakenied merged 1 commit into
LMBishop:masterfrom
FireML:evenmorefish-api
Aug 12, 2026
Merged

Use EvenMoreFish API#883
Krakenied merged 1 commit into
LMBishop:masterfrom
FireML:evenmorefish-api

Conversation

@FireML

@FireML FireML commented Aug 10, 2026

Copy link
Copy Markdown
Contributor
  • Updated EvenMoreFish to 2.1.2 and compiles against the API artifact.
  • Replaced deprecated EMFFishEvent with EMFFishCaughtEvent.
  • Replaced deprecated EMFFishHuntEvent with API alternative.
  • Replaced Fish objects with IFish and uses the AbstractFishManager to fetch them.

Closes #830 and resolves deprecation warnings when using EvenMoreFish:

[16:18:44 WARN]: [Quests] "Quests v3.16.1-430c34a" has registered a listener for com.oheers.fish.api.EMFFishEvent on method "public void com.leonardobishop.quests.bukkit.tasktype.type.dependent.EvenMoreFishFishingTaskType.onEMFFish(com.oheers.fish.api.EMFFishEvent)", but the event is Deprecated. "Server performance will be affected"; please notify the authors [LMBishop & contributors].
[16:18:44 WARN]: [Quests] "Quests v3.16.1-430c34a" has registered a listener for com.oheers.fish.api.EMFFishHuntEvent on method "public void com.leonardobishop.quests.bukkit.tasktype.type.dependent.EvenMoreFishHuntingTaskType.onEMFFishHunt(com.oheers.fish.api.EMFFishHuntEvent)", but the event is Deprecated. "Server performance will be affected"; please notify the authors [LMBishop & contributors].

@Krakenied Krakenied self-assigned this Aug 11, 2026
@Krakenied

Krakenied commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

Do we want to drop support for older EMF versions? Up to you, I don't really care lol.

@FireML

FireML commented Aug 12, 2026

Copy link
Copy Markdown
Contributor Author

The version I bumped to is 9 months old at this point, but I could fall back to the deprecated stuff if needed.

@Krakenied

Copy link
Copy Markdown
Collaborator

Added a check. Will include info about dropping support for older versions in next release.

@Krakenied
Krakenied merged commit 6d07f47 into LMBishop:master Aug 12, 2026
2 checks passed
@Krakenied

Copy link
Copy Markdown
Collaborator

ty

@FireML
FireML deleted the evenmorefish-api branch August 13, 2026 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incompatibility with EvenMoreFix 2.x

2 participants