fix: make soroban event processing idempotent - #1342
Open
d1a-m3n wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes duplicate
fee_collectedevents being processed more than once by the Soroban event worker.The worker now checks whether a
StreamEventhas already been recorded before creating another one. This keeps event processing idempotent and prevents duplicate fee collection records when the same event is received again.Type of Change
Related Issues
Closes #1220
Changes Made
fee_collectedevents.StreamEventrecords from being created.Testing
I ran the Soroban event worker test suite locally.
Test Coverage
Test Steps
fee_collectedevent test passes.StreamEvent.Result: 13/13 tests passed.
Breaking Changes
None.
Screenshots/Demo
Not applicable.
Checklist
Additional Notes
The targeted test file passes all 13 tests. The project's global coverage threshold can cause the full test command to exit with a coverage error when running only this individual test file, but there are no failing tests in the file itself.