Unread notification count - #1406
Merged
Merged
Conversation
…m clears paused, test for pause→cancel→resume
…m clears paused, test for pause→cancel→resume
…nouncements of notification count changes\n\n- Move aria-live region outside button element\n- Make live region always present (not conditional on unreadCount > 0)\n- Ensures screen readers re-announce 'N new notifications' when count increases\n\nFixes: NotificationDropdown.tsx:142-150 - badge only conveyed via button's aria-label\n\nCo-authored-by: opencode
cancel_stream clears paused (lib.rs:802), so test now correctly asserts !s.paused instead of s.paused. Resolves audit issue #21.
… to NotificationDropdown
akinerin
force-pushed
the
Unread_notification_count
branch
from
September 4, 2026 00:11
fa44ccf to
6842ef7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1258