fix(governance): remove KEY_LAST_CANCELLED_AT from finalize_admin_tra… - #1727
Open
laxjovial wants to merge 1 commit into
Open
fix(governance): remove KEY_LAST_CANCELLED_AT from finalize_admin_tra…#1727laxjovial wants to merge 1 commit into
laxjovial wants to merge 1 commit into
Conversation
…nsfer finalize_admin_transfer incorrectly set KEY_LAST_CANCELLED_AT on successful finalization, treating a completed transfer as a cancellation. This locked the new admin out of submitting governance proposals for 1 hour (REPROPOSAL_COOLDOWN_SECONDS) immediately after taking office. Remove the erroneous write so the cooldown is only enforced after actual cancellations. Add regression test confirming the new admin can propose immediately after finalization. Fixes LabsCrypt#1664
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Remove
KEY_LAST_CANCELLED_ATfromfinalize_admin_transferCloses #1664
Problem
multisig_governance::finalize_admin_transferwas settingKEY_LAST_CANCELLED_ATupon successful finalization of an admin transfer. This storage key is used bypropose_admin_transferto enforce a 1-hour cooldown (REPROPOSAL_COOLDOWN_SECONDS) after a proposal is cancelled — preventing spam/repeated failed attempts.By setting it on successful finalization, a completed transfer was treated the same as a cancellation, locking the new admin out of submitting any governance proposals for 1 hour immediately after taking office.
Root Cause