fix: interval test expectations and conversion for 365-day year - #47
Merged
Conversation
adsharma
force-pushed
the
fix/timestamp-tz
branch
from
July 23, 2026 21:00
caa97f9 to
3735459
Compare
The engine Interval::getMicro fix (DAYS_PER_YEAR for whole years) has been merged to engine main. Update: - src_cpp/py_query_result.cpp: use DAYS_PER_YEAR (365) for whole years - src_py/_lbug_capi.py: same for C-API interval conversion sites - test/ expectations: 1082->1097 days, 3750->3800 days, 9414->9544 days
adsharma
force-pushed
the
fix/timestamp-tz
branch
2 times, most recently
from
July 24, 2026 03:26
1ca3cc1 to
6f3b4ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: LadybugDB/ladybug#694
The engine Interval::getMicro fix (DAYS_PER_YEAR for whole years) has been merged to engine main (#723). Update Python bindings to match: