Honor concrete width proposals in UIKit sizeThatFits - #27
Open
felipefdl wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26.
On iOS,
_TextView_UIKit.sizeThatFitsreturneduiView.sizeThatFits(...)directly.UITextView.sizeThatFitsreports the used (snug) width, so SwiftUI sized the representable to its longest line. Inside flexible containers, short-lined content (ordered lists through MarkdownView'sMarkdownText, for example) collapsed into a narrow column: 98 pt in a 390 pt window, with list head indents wrapping item text character by character andcopy(_:)truncating at the laid-out region.This change honors a concrete width proposal and keeps the fitted size only when the proposal has no width, matching how the AppKit path fills its container. Verified on an iOS 26 simulator with the reproduction test from #26: the collapsed case goes from 98 pt to the proposed 358 pt, long prose is unchanged, and streaming updates stay correct.