feat: team roster display - #8017
Draft
ElectricalBoy wants to merge 3 commits into
Draft
Conversation
Collaborator
|
Feels like we need something visual to distinguish from normal TeamParticipants, especially for the Qualifier/Tournament part. Not great to have it mean something different here compare to what it means on tournament pages. |
Collaborator
Author
|
agreed - I'm not a huge fan of overloading the design of TeamParticipants either but since this is only a POC I didn't care as much |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #8014
Notes
This PR is a proof-of-concept implementation. It does not meet good coding standards set in our repository and will need to be refactored before being marked as ready for review.
How did you test this change?
https://liquipedia.net/leagueoflegends/User:ElectricalBoy/Sandbox8