feat: expose stat-linked achievement progress in expanded achievements#391
Merged
Merged
Conversation
Reads each achievement's schema progress block (max_val, min_val, and the linked stat via value.operand1), resolves the current value from the user's stats, and exposes progressCurrent/progressMax plus a hasProgress flag on AchievementBlocks. Progress achievements can now show a current/max bar.
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stat-linked "progress" achievements — the ones Steam shows as e.g.
45 / 100— now surface their progress throughgetExpandedAchievements.For each achievement, the schema
progressblock is read (max_val,min_val, and the linked stat fromvalue.operand1) and matched against the user's current stat values. Three additions toAchievementBlocks:progressCurrent— current value, normalized so0 == min_valprogressMax—max_val - min_valhasProgress— true when the achievement tracks progressRegular unlock/locked achievements are untouched (both fields stay
null). A newtestGetExpandedAchievementsWithProgresscovers the parsing against a mock schema.Verified end to end in GameNative, which renders the values as a progress bar in the achievements list.
Same change opened against the GameNative fork joshuatam/JavaSteam: joshuatam#15
Checklist