Use colors in fallback - #24
Merged
Merged
Conversation
Add inherit_stdio parameter to Exec trait and all implementations. Update command modules to use new parameter and return Option<String> for error handling. Adjust tests and error propagation accordingly.
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the command execution interface to add color support for fallback operations. The main change is adding an inherit_stdio parameter to the Exec trait to control whether git commands inherit stdio from the parent process or capture their output.
- Updated the
Exectrait to include aninherit_stdioparameter for controlling output handling - Modified all command implementations to pass
falsefor the new parameter except in fallback scenarios - Changed error handling from
StringtoOption<String>to better support cases where errors shouldn't display messages
Reviewed Changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/commands.rs | Added inherit_stdio parameter to Exec trait and implemented stdio inheritance logic |
| src/commands/git_fallback.rs | Updated to use inherit_stdio: true for color output in fallback commands |
| src/main.rs | Modified error handling to work with Option<String> return types |
| src/utils.rs | Updated function signatures and all exec calls to include the new parameter |
| src/commands/*.rs | Updated all command modules to use the new exec signature with inherit_stdio: false |
| Cargo.toml | Version bump to 0.9.1 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.