Skip to content

Fix oneplus_13_b CI build failure caused by KernelSU sucompat hook symbol drift - #1

Merged
Lyn6969 merged 2 commits into
SukiSU-Ultrafrom
copilot/fix-failing-github-actions-job
Sep 26, 2026
Merged

Lyn6969 merged 2 commits into
SukiSU-Ultrafrom
copilot/fix-failing-github-actions-job

Conversation

Copilot AI commented Sep 26, 2026 •

Copy link
Copy Markdown

The [FAST] [KPM] [BBG] [HMBIRD] For oneplus_13_b job failed at link time because fs/exec.c referenced ksu_handle_post_execveat_sucompat, but that symbol is not consistently present across the KernelSU variants pulled by this workflow. This change adds a targeted workflow-side compatibility guard to normalize that hook call before build.

  • Root cause surfaced by failed job

    • Linker error on undefined ksu_handle_post_execveat_sucompat during vmlinux link.
  • Workflow compatibility fix

    • Added a new step in .github/workflows/Build Kernel OnePlus.yml:
      • detect whether fs/exec.c contains ksu_handle_post_execveat_sucompat
      • if the symbol implementation exists in KernelSU sources, leave unchanged
      • if missing:
        • rewrite to ksu_handle_execveat_sucompat when available, otherwise
        • remove the stale incompatible hook invocation line
  • Behavioral scope

    • Guarded/no-op for unaffected builds.
    • Applies only when symbol reference/implementation mismatch is detected.
HOOK_NAME="ksu_handle_post_execveat_sucompat"

if grep -q "$HOOK_NAME" ./fs/exec.c; then
  if grep -Rqs --include='*.c' "$HOOK_NAME" ./drivers/kernelsu ./KernelSU; then
    : # implementation present
  elif grep -Rqs --include='*.c' 'ksu_handle_execveat_sucompat' ./drivers/kernelsu ./KernelSU; then
    sed -i "s/\b${HOOK_NAME}\b/ksu_handle_execveat_sucompat/g" ./fs/exec.c
  else
    sed -i "/\b${HOOK_NAME}[[:space:]]*(/d" ./fs/exec.c
  fi
fi

Co-authored-by: Lyn6969 <42564665+Lyn6969@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix the failing GitHub Actions job for OnePlus 13 B Fix oneplus_13_b CI build failure caused by KernelSU sucompat hook symbol drift Sep 26, 2026
Copilot AI requested a review from Lyn6969 September 26, 2026 14:14
@Lyn6969
Lyn6969 marked this pull request as ready for review September 26, 2026 14:28
Copilot AI lite review requested due to automatic review settings September 26, 2026 14:28
@Lyn6969
Lyn6969 merged commit d31d968 into SukiSU-Ultra Sep 26, 2026
2 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-26T14:29:19.810757Z 66fb10d Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The workflow may miss valid implementations and leave undefined symbol references unresolved.

Review effort: Lite
Findings: 1 High severity

Open (1)
What changed in this PR

This PR adds a workflow guard to handle KernelSU sucompat hook symbol drift during the OnePlus kernel build.

Changes:

  • Detects the stale hook reference.
  • Replaces it with an available alternate symbol or removes it.
  • Searches KernelSU sources before compilation.
File Summary
.github/​workflows/​Build Kernel OnePlus.yml Adds compatibility handling, but uses an incorrect KernelSU path and text-only symbol detection.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

exit 0
fi

if grep -Rqs --include='*.c' "$HOOK_NAME" ./drivers/kernelsu ./KernelSU 2>/dev/null; then
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants