Fix oneplus_13_b CI build failure caused by KernelSU sucompat hook symbol drift - #1
Merged
Merged
Conversation
Co-authored-by: Lyn6969 <42564665+Lyn6969@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix the failing GitHub Actions job for OnePlus 13 B
Fix oneplus_13_b CI build failure caused by KernelSU sucompat hook symbol drift
Sep 26, 2026
Lyn6969
marked this pull request as ready for review
September 26, 2026 14:28
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The workflow may miss valid implementations and leave undefined symbol references unresolved.
Review effort: Lite
Findings: 1
What changed in this PR
This PR adds a workflow guard to handle KernelSU sucompat hook symbol drift during the OnePlus kernel build.
Changes:
- Detects the stale hook reference.
- Replaces it with an available alternate symbol or removes it.
- Searches KernelSU sources before compilation.
| File | Summary |
|---|---|
.github/workflows/Build Kernel OnePlus.yml |
Adds compatibility handling, but uses an incorrect KernelSU path and text-only symbol detection. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| exit 0 | ||
| fi | ||
|
|
||
| if grep -Rqs --include='*.c' "$HOOK_NAME" ./drivers/kernelsu ./KernelSU 2>/dev/null; then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The
[FAST] [KPM] [BBG] [HMBIRD] For oneplus_13_bjob failed at link time becausefs/exec.creferencedksu_handle_post_execveat_sucompat, but that symbol is not consistently present across the KernelSU variants pulled by this workflow. This change adds a targeted workflow-side compatibility guard to normalize that hook call before build.Root cause surfaced by failed job
ksu_handle_post_execveat_sucompatduringvmlinuxlink.Workflow compatibility fix
.github/workflows/Build Kernel OnePlus.yml:fs/exec.ccontainsksu_handle_post_execveat_sucompatksu_handle_execveat_sucompatwhen available, otherwiseBehavioral scope