fix: improve runtime stability and compact settings headers - #220
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repeated badge refreshes after a blocked JNI syscall create another worker on every timeout. Limit each native query to one worker until the syscall actually finishes, using separate permits for SU and KPM counts. Busy or timed-out queries keep their last known count and log the query name, so a stuck SU query cannot block KPM counting or reset an existing badge to zero.
Fix the PTY window listener's busy loop on a non-TTY stdout: retry
TIOCGWINSZonEINTR, but log and stop on persistent errors such asENOTTY. Checkpthread_sigmaskandsigwaitreturn codes. Keep SIGWINCH blocked forsigwaitthrough the inherited mask rather than unblocking it in the listener.Settings sub-pages currently open with a large expanded title below the back button, leaving excessive space above the first setting. Switch the shared settings scaffold to a pinned, single-line TopAppBar with the title beside the back arrow, titleLarge typography, and ellipsis for long labels. This makes all eight category sub-pages compact on entry while preserving the shared scrolled colour treatment.
Add
-PkernelPatchArtifacts=/absolute/path/to/artifactsto package nonempty localkpimg-androidandkptools-android. Read the property and resolve paths during configuration; task actions capture files instead of the Project or Gradle script instance. Omitting the property restores published assets. Usage is documented in the build-script comments.Related kernel changes: LyraVoid/KernelPatch#7. Using that repaired Boot-mode kernel requires building its kpimg/kptools and supplying the local artifacts.
Validation:
python3 scripts/test_stability.pypasses: counted worker callbacks stay at zero during 1,000 blocked-query retries, the fallback is retained, an independent query succeeds, and the blocked query resumes after completion.AppData.ktat base6b2a37d7: 1,000 extra workers execute and the JVM exits with status 1 on the counter assertion.--baseline-ref 6b2a37d7 --expect-regressionchecks this failure explicitly, rather than treating any exception as success.python3 scripts/test_kernel_artifacts.pypasses in an isolated Gradle build: configuration-cache storage/reuse, copying updated artifacts, and rejecting missing/empty artifacts. This tests the actual download-task code without Android plugins; it does not claim configuration-cache support for every task in the project.6448dc2fwith JDK 21: https://github.com/LyraVoid/FolkPatch/actions/runs/37006617400.git diff --checkpasses. Previous commits passed GitHub Android builds; the latest commit's Debug/Release builds are running. Full local Android/Rust builds remain unavailable due to missing dependencies/toolchain, and no device validation has been performed.