Skip to content

Make browser extension generation deterministic - #2

Merged
M-Colley merged 2 commits into
mainfrom
copilot/fix-browser-actions-job
Sep 13, 2026
Merged

M-Colley merged 2 commits into
mainfrom
copilot/fix-browser-actions-job

Conversation

Copilot AI commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

The browser GitHub Actions job was failing even when the browser engine checks passed. The failure came from browser/build-extension.mjs regenerating extension/engine.js with a day-dependent header, causing a diff on every later run.

  • Root cause

    • extension/engine.js included a generated Built: YYYY-MM-DD line.
    • The workflow intentionally rebuilds the extension engine and fails if the committed output changes, so the timestamp created daily false-positive drift.
  • Change

    • Remove the date stamp from the generated header in browser/build-extension.mjs.
    • Regenerate extension/engine.js so the committed artifact matches the stable generator output.
  • Effect

    • Re-running the browser extension build no longer changes extension/engine.js unless the actual engine source changes.
    • The workflow still preserves its sync check between browser/mechcheck.html and the extension copy.
const header = `/* GENERATED FILE -- do not edit.
 *
 * Built from browser/mechcheck.html by browser/build-extension.mjs, so the
 * extension and the standalone page run byte-for-byte the same checks. Edit
 * mechcheck.html and re-run the build.
 */
`;

Co-authored-by: M-Colley <39366189+M-Colley@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing GitHub Actions job "browser" Make browser extension generation deterministic Sep 13, 2026
Copilot AI requested a review from M-Colley September 13, 2026 10:17
@M-Colley
M-Colley marked this pull request as ready for review September 13, 2026 10:23
@M-Colley
M-Colley merged commit 55841d5 into main Sep 13, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants