Make browser extension generation deterministic - #2
Merged
Merged
Conversation
Co-authored-by: M-Colley <39366189+M-Colley@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job "browser"
Make browser extension generation deterministic
Sep 13, 2026
M-Colley
marked this pull request as ready for review
September 13, 2026 10:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
browserGitHub Actions job was failing even when the browser engine checks passed. The failure came frombrowser/build-extension.mjsregeneratingextension/engine.jswith a day-dependent header, causing a diff on every later run.Root cause
extension/engine.jsincluded a generatedBuilt: YYYY-MM-DDline.Change
browser/build-extension.mjs.extension/engine.jsso the committed artifact matches the stable generator output.Effect
extension/engine.jsunless the actual engine source changes.browser/mechcheck.htmland the extension copy.