Compile the macOS front end - #16
Merged
Merged
Conversation
The macOS job is the first machine to have built it, and it found what was waiting: onChange without an argument is macOS 14 and this targets 13, and a conditional between two implicit member colours has no type to infer from. Both are the kind of thing no amount of reading finds. Three things fixed while the build was red anyway. The view is on the main actor, which is where it was going to end up. main.swift is now MThreadDrawApp.swift, so @main stands on its own and the package needs no unsafe compiler flag to allow it. And standard error is drained rather than left to fill: a pipe nobody reads stops at 64 KB and the writer blocks for ever, so the engine would have hung instead of failing - and its last words are exactly what says why.
The previous commit pushed a Swift string literal with an actual line break in it, which does not compile. Written by a script whose escapes did not survive the trip through the shell.
The paths that trigger this workflow listed the packaging scripts but not the two applications they package, so the commit that fixed the macOS build could not run the macOS build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The macOS job in #15 was the first machine ever to compile the Swift front end, and it failed - which is what that job is for. Two real errors:
onChange(of:)without an argument in the closure is macOS 14, and the app targets 13..white.opacity(...)and.clear) gives the generic shape-style parameter nothing to infer from.Three things fixed while it was red anyway: the view is on the main actor,
main.swiftbecameMThreadDrawApp.swiftso@mainstands without an unsafe compiler flag, and standard error is drained rather than left to fill - a pipe nobody reads stops at 64 KB and the writer blocks for ever, so the engine would have hung instead of failing, and its last words are what says why.The workflow also now triggers on
macos/**andwinui/**. It did not, which is why the fix for the macOS build could not run the macOS build.