The disk images were empty, and the wheel had the old version - #19
Merged
Conversation
Both found by looking at what v1.3.0 actually published rather than at what the build said. The .dmg files were 280 KB. The engine is built into a staging directory outside the checkout now - OneDrive holds handles on files in a synced folder - and tools/build_macos.py still looked in dist/, found nothing, printed a warning, and assembled a bundle without it. A bundle that looks finished and does nothing on any machine without a checkout of this repository. It imports the staging path from build_app now instead of repeating it, and refuses outright rather than warning: --no-engine is there for the case where the window alone is what you want. The wheel and sdist said 1.2.0 because the version lived in three places and the bump touched two of them. pyproject reads it from mthread_draw.__version__ now, so there is one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both found by looking at what
v1.3.0actually published rather than at what the build said. Zero downloads, so the release and tag are being replaced rather than followed by a 1.3.1.280 KB disk images
The engine is built into a staging directory outside the checkout now — OneDrive holds handles on files inside a synced folder — and
tools/build_macos.pystill looked only indist/. It found nothing, printed a warning, and assembled the bundle anyway: an application that looks finished, weighs 300 KB, and does nothing on any machine without a checkout of this repository.It imports the staging path from
build_appnow rather than repeating it, and it refuses outright instead of warning.--no-engineexists for the case where the window alone is genuinely what you want.A 1.2.0 wheel in a 1.3.0 release
The version lived in three places — both
__init__.pyfiles andpyproject.toml— and the bump touched two.pyprojectnow reads it frommthread_draw.__version__, so there is one. Verified:python -m build --sdistproducesmthread_draw-1.3.0.tar.gz.205 tests pass.