feat(settings): restore news filter ordering in customization (#311)#318
Open
cassio-rossi wants to merge 1 commit into
Open
feat(settings): restore news filter ordering in customization (#311)#318cassio-rossi wants to merge 1 commit into
cassio-rossi wants to merge 1 commit into
Conversation
Restore CustomNewsView, deleted in 0f22512 after being disabled in d85e32c, letting users drag-reorder the News filter options. All supporting infrastructure (CustomizationDB.news, CustomizationViewModel, Database.update(news:), newsOrder analytics, sidebar/initial-selection consumers) was still present, so only the view and its SettingsView call site needed restoring. Copy reworded to reference the news filters. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores the News filter ordering option in Settings → Customização do app, letting users drag-reorder the News filter options (Todas, Últimas Notícias, Destaques, Apple TV, Reviews, Rumores, Tutoriais).
The feature was removed in two steps:
d85e32cb"Delete readpost" — disabled it (CustomNewsView()→// CustomNewsView())0f22512b"remove dead code…" — deletedCustomNewsView.swiftAll supporting infrastructure was still present and wired, so only the view and its call site needed restoring:
CustomizationDB.news,CustomizationViewModel.news/.change(_ news:)Database.update(news:),AnalyticsConstants.GenericEvent.newsOrderSettingsViewModel.news→ iPad sidebar order + initial selectionChanges
SettingsLibrary/Views/Supplementals/CustomNewsView.swift— restored, mirroringCustomSocialView; copy reworded to reference the news filters.SettingsLibrary/Views/SettingsView.swift—CustomNewsView()reinserted betweenCustomTabView()andCustomSocialView().Quality gates
--strict): 0 violations** BUILD SUCCEEDED **(iPhone 17 Pro Max, OS 26.5 — iPhone 17 Pro runtime not installed locally)** TEST SUCCEEDED **— 44 tests, 5 suitesRelates to #311
🤖 Generated with Claude Code