filing: failed hardlink no longer writes the processed-book marker - #29
Draft
cursor[bot] wants to merge 1 commit into
Draft
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
A cross-device (or otherwise failed) hardlink still cached the book under __cache__/book, which never expires, so the next run skipped it and the files never reached the library. Write the marker only when every file was filed or dedupe_roots already has the release. Co-authored-by: Mancolt <Mancolt@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A matched book whose hardlink (or copy) failed — typically
source_pathandmedia_pathon different filesystems (EXDEV) — was still given the never-expiring__cache__/bookmarker. Later runs printedSkipping: … already processedand the files never reached the library. The default template uses/data/torrents/downloadsand/data/media/audiobooks/mam, which are often different volumes.Fix: write the processed marker only when every file was filed, or when
dedupe_rootsalready has the release.isHardlinkedis set on dest-exists (a sibling disc that linked last run) and cleared on exception (a staleisHardLinked=Truefrom the log). A calibre ingest success does not hide a failed media-path filing.Validation:
python3 -m unittest discover -s tests -p 'test_*.py'— 224 tests, 0 failures. New cases cover EXDEV then retry, dest-exists, stale log flag, and calibre vs media-path.