mam: ranking no longer requires verbose - #30
Draft
cursor[bot] wants to merge 1 commit into
Draft
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
getMAMBooks nested interactive pick and automatic ranking under Config/flags/verbose, so a run with verbose off left bestMAMMatch unset even when MAM returned snatched hits. metadata=mam then filed nothing; mam-audible skipped MAM and foreign-language detection. Ranking now matches _rankAudible: verbose only gates the count line. Co-authored-by: Mancolt <Mancolt@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MAM ranking and the interactive pick lived under
if (verbose):ingetMAMBooks. WithConfig/flags/verboseoff (a documented flag),bestMAMMatchstayed unset even when MAM returned snatched hits.Impact:
metadata=mamfiled nothing. Defaultmam-audibleskipped MAM and foreign-language detection and searched Audible from id3 only.Fix: Un-indent ranking to match
_rankAudible— verbose only gates theFound N MAM match(es)line. Title/author gates are unchanged.Validation:
MamRankingWithoutVerboseTest(accept + reject with verbose=0). Full suite 223 tests OK. Correctness and security review of the diff: no findings.