mam-audible: search Audible from id3 when MAM finds nothing - #31
Draft
cursor[bot] wants to merge 1 commit into
Draft
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Default metadata=mam-audible passed bestMAMMatch into getAudibleBooks even when MAM missed. getAudibleBooks(None) never searches, so a file with usable id3 tags stayed unmatched unless a pin supplied an ASIN. Co-authored-by: Mancolt <Mancolt@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default
metadata=mam-audiblepassedbestMAMMatchintogetAudibleBookseven when MAM found nothing.getAudibleBooks(None)never searches, so a file with usable id3 tags stayed unmatched unless a pin supplied an ASIN.Impact: The default metadata mode skipped Audible entirely on a MAM miss (book not snatched, search miss, or empty result). Those releases never matched and were never filed.
Fix: When MAM found nothing, pass the file's tags (
ffprobeBook) — the same sourcemetadata=audiblealready uses. An English MAM hit still searches from MAM metadata. Foreign, multibook, and collection paths are unchanged.Validation:
MamAudibleFallbackTest—getAudibleBooks(None)makes no requests; hybridbuildTreeFromHybridSourceswith a MAM miss matches from id3. The hybrid test fails without the fix (isMatchedstays False). Full suite 225 tests OK. Correctness and security review of the diff: no findings.