Skip to content

Make the material attribute in HitRecord a reference instead of a Trait object #3

Description

@Mandragorian

The material attribute in the HitRecord struct is a Trait object. This is not needed, since the HitRecord shouldn't own a copy of the material, and it is also innefficient, since a copy of the material struct takes place.

Instead, the material attribute should be defined as a reference to something that implements the Material trait.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions