Removes the default override for the 2D colormap action - #157
Merged
Merged
Conversation
…lt) for the 2D colormap action This fixes the issue caused by the colormap name adjustment in the core but is generally a bit more general, as the current default was just using the actions initializer default, so simply removing it keeps identical functionality.
ThomasKroes
approved these changes
Jul 23, 2026
thoellt
added a commit
to ManiVaultStudio/core
that referenced
this pull request
Jul 23, 2026
* Prepares PointRenderer for more extensive coloring modes in scatterplot This extends the PointRenderer with generalized 2D (the previous position based 2D mode is kept for comparison) and 3D RGB coloring modes. We are adding new 2D and 3D buffers to the shaders and direct lookup in the fragment shader. PointRenderer manages the new buffers as vertex attributes. It prepares core rendering functionality for Scatterplot issue 24 (ManiVaultStudio/Scatterplot#24) The idea is to allow e.g., coloring the points in a scatterplot of a hyperspectral imaging dataset using color from a co-registered RGB image (3D case) or to apply the Embedding position coloring but using a different embedding. e.g., UMAP to t-SNE or between embeddings of two different modalities of the same object. * Renames 2D colormaps to credit the original authors Note this addition breaks the default 2D colormap in the image viewer (a working one can still be selected, so its not a breaking issue). A one line fix is provided in the image viewer pull request #157 (ManiVaultStudio/ImageViewerPlugin#157)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issue caused by the colormap name adjustment in the core but is generally a bit more general, as the current default was just using the actions initializer default, so simply removing it keeps identical functionality.