Merge from master - #257
Open
ThomasKroes wants to merge 20 commits into
Open
Conversation
* Update number of points to uint64 * Use reference dataset * Add some const * Rename lambda capture variable to not shadow function paramters * More uint64 * Set MSVC warning level to W3 * We only want one dataset
* Use new getter for clarity (avoid negation) (#242) * Use `mv_project_defaults()` for setting CMake defaults (#241) * Use mv project defaults * Simplify unity build setup * Prefer target based properties * Set cache variable instead of normal variable for CMake option * Adhere to revamped core --------- Co-authored-by: Alexander Vieth <a.vieth@tudelft.nl>
…ction_for_non_descendants Ffix opacity selection for non descendants
Adds 2D and 3D coloring options. 2D allows arbitrary 2 channels using the build in 2D colormaps 3D allows arbitrary 3 channels mapping directly to RGB (normalized in shader) Modes are automatically picked when datasets with exactly 2 or 3 channels are set as color or can be manually set using the extended color action Renames 2D colormaps according to their authors
Replaced deprecated 'mirrored' method with 'flipped' for color maps.
Updated build workflow to use newer versions of actions and Python.
* Revert principle dimension action name change * Ignore loading errors for newly introduced actions Do this for backwards compatibility
…they provide full coverage
* Remove restrictive condition * Use range for, eliminates index * Check if cluster indices exceed point indices instead of checking of they provide full coverage * link against tbb with gcc
* Add configurable scatterplot z ordering Introduce a dedicated `ZOrderingAction` for choosing point depth order by insertion order, dimension, or randomized mode, and expose it in the settings toolbar/menu. The scatterplot plugin and widget now support data-driven z-order scalars, update z ordering when position data changes, and migrate older saved settings that stored randomized depth under miscellaneous options. * Restrict selection by Z-order threshold Add Z-order selection filtering with a configurable minimum value and enable/disable toggle, wired through `ZOrderingAction` and mirrored in `SelectionAction`. Selection operations now respect excluded points (interactive select, sample, select all, invert), widget highlights are masked for excluded indices, and the HUD reports effective selected vs selectable point counts. * Extract selection restriction into shared action Introduces a new `SelectionRestrictionAction` to manage selection filtering by dimension and value range, and wires it into `SelectionAction` with full serialization/linking support. This removes the old Z-order-specific threshold controls from `ZOrderingAction`, keeps Z-order focused on depth ordering, and adds a trigger to copy the current Z-order dimension into the selection restriction when needed. `SettingsAction` initialization/member order was also adjusted so the shared selection restriction is available where it is referenced. * Couple z-ordering with selection restriction Replace the one-shot "use Z-order dimension" action with a persistent toggle that keeps Z-ordering and selection restriction in sync, including shared dimension updates and range enablement. This also loads selection settings earlier so the coupled state restores correctly, and hides labels in the selection restriction group for a cleaner embedded UI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge the current master branch into release/core_bican_bg/bican_bg for the bican_bg release bundle.
Automated PR created from the release configuration. Please review conflicts and build/runtime compatibility before merging.