Adhere to updated core serialization and parallelization API - #128
Merged
ThomasKroes merged 3 commits intoJul 1, 2026
Merged
Conversation
Add #include <util/Serialization.h> to CrossSpeciesComparisonGeneDetectPlugin.cpp so the plugin can use serialization utilities. This ensures serialization types/functions are available where needed and tidies up the include ordering.
Prefix Dataset, Points and Clusters types with the mv:: namespace in headers to remove ambiguity and ensure correct type resolution. Updated member variables and getter return types in src/CrossSpeciesComparisonGeneDetectPlugin.h and src/SettingsAction.h. No behavioral changes intended, only type qualification.
ThomasKroes
added a commit
that referenced
this pull request
Aug 18, 2026
* restructure code[skip ci] * add license * remove debug message[skip ci] * Add using namespace mv * Adhere to updated core serialization and parallelization API (#128) * Include util::Serialization in plugin Add #include <util/Serialization.h> to CrossSpeciesComparisonGeneDetectPlugin.cpp so the plugin can use serialization utilities. This ensures serialization types/functions are available where needed and tidies up the include ordering. * Qualify Dataset types with mv:: namespace Prefix Dataset, Points and Clusters types with the mv:: namespace in headers to remove ambiguity and ensure correct type resolution. Updated member variables and getter return types in src/CrossSpeciesComparisonGeneDetectPlugin.h and src/SettingsAction.h. No behavioral changes intended, only type qualification. * Update SettingsAction.h * Fix includes * change repo name * update conan file * Update conanfile.py --------- Co-authored-by: Soumyadeep Basu <44787782+basusoumyadeep@users.noreply.github.com> Co-authored-by: sbasu <sbasu@2026-8202.local> Co-authored-by: Soumyadeep Basu <44787782+sbvis@users.noreply.github.com> Co-authored-by: Soumyadeep Basu <soumyadeepbs880@gmail.com>
ThomasKroes
added a commit
that referenced
this pull request
Sep 10, 2026
* restructure code[skip ci] * add license * remove debug message[skip ci] * Add using namespace mv * Adhere to updated core serialization and parallelization API (#128) * Include util::Serialization in plugin Add #include <util/Serialization.h> to CrossSpeciesComparisonGeneDetectPlugin.cpp so the plugin can use serialization utilities. This ensures serialization types/functions are available where needed and tidies up the include ordering. * Qualify Dataset types with mv:: namespace Prefix Dataset, Points and Clusters types with the mv:: namespace in headers to remove ambiguity and ensure correct type resolution. Updated member variables and getter return types in src/CrossSpeciesComparisonGeneDetectPlugin.h and src/SettingsAction.h. No behavioral changes intended, only type qualification. * Update SettingsAction.h * Fix includes * change repo name * update conan file * Update conanfile.py --------- Co-authored-by: Soumyadeep Basu <44787782+basusoumyadeep@users.noreply.github.com> Co-authored-by: sbasu <sbasu@2026-8202.local> Co-authored-by: Soumyadeep Basu <44787782+sbvis@users.noreply.github.com> Co-authored-by: Soumyadeep Basu <soumyadeepbs880@gmail.com>
ThomasKroes
added a commit
that referenced
this pull request
Sep 16, 2026
* restructure code[skip ci] * add license * remove debug message[skip ci] * Add using namespace mv * Adhere to updated core serialization and parallelization API (#128) * Include util::Serialization in plugin Add #include <util/Serialization.h> to CrossSpeciesComparisonGeneDetectPlugin.cpp so the plugin can use serialization utilities. This ensures serialization types/functions are available where needed and tidies up the include ordering. * Qualify Dataset types with mv:: namespace Prefix Dataset, Points and Clusters types with the mv:: namespace in headers to remove ambiguity and ensure correct type resolution. Updated member variables and getter return types in src/CrossSpeciesComparisonGeneDetectPlugin.h and src/SettingsAction.h. No behavioral changes intended, only type qualification. * Update SettingsAction.h * Fix includes * change repo name * update conan file * Update conanfile.py * Update conanfile.py --------- Co-authored-by: Soumyadeep Basu <44787782+basusoumyadeep@users.noreply.github.com> Co-authored-by: sbasu <sbasu@2026-8202.local> Co-authored-by: Soumyadeep Basu <44787782+sbvis@users.noreply.github.com> Co-authored-by: Soumyadeep Basu <soumyadeepbs880@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.