Fix map sketching points order - #4649
Open
tomasMizera wants to merge 2 commits into
Open
Conversation
tomasMizera
changed the title
Coverage Report for CI Build 31638925720Coverage decreased (-0.008%) to 59.094%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions73 previously-covered lines in 2 files lost coverage.
Coverage Stats
馃挍 - Coveralls |
馃摝 Build Artifacts Ready
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts the order in which we add points to map sketching lines. Previously we prepended points, which resulted in points being stored in reversed order, starting with the last. Now we append points. This feels natural and it was a missed todo in map sketching code.
The request came from the community, see https://community.merginmaps.com/p/line-vertices - this will enable easy setup of arrow symbology.
There were a couple of JS runtime exceptions in the code that I fixed along the way:
On map sketching drawer open:
On color selection:
No UI/UX change. Map sketching works just like before.