fix: correct nativeCurrency typo in network search - #45652
Open
crazywriter1 wants to merge 4 commits into
Open
Conversation
Fuse.js was searching 'nativeCrrency' instead of 'nativeCurrency', so ticker searches (e.g. BNB, ETH) in the network menu did not work.
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
nativeCrrencyinstead ofnativeCurrency, so searching by ticker (e.g. BNB, ETH) never matched.nativeCurrencyand add a regression test that searches forBNB.Changelog
CHANGELOG entry: Fixed network menu search by native currency symbol
Related issues
Fixes: N/A
Manual testing steps
BNB→ BNB Smart Chain appears; unrelated networks are filtered out.ETH→ Ethereum-related networks match.yarn test:unit ui/components/multichain/network-list-menu/network-list-menu.test.tsx --runInBandScreenshots/Recordings
N/A
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
UI-only search typo fix with a regression test; no auth, data, or network-switching logic changes.
Overview
Fixes network menu search so queries like
BNBorETHmatch networks by their native currency ticker, not only name or chain ID.The Fuse.js config used a misspelled field (
nativeCrrency), so thenativeCurrencyproperty was never searched. The key is corrected tonativeCurrency.A unit test searches for
BNBand asserts BNB Smart Chain stays visible while unrelated networks (e.g. Chain 5) are filtered out.Reviewed by Cursor Bugbot for commit eb90832. Bugbot is set up for automated code reviews on this repo. Configure here.