Skip to content

fix: correct nativeCurrency typo in network search - #45652

Open
crazywriter1 wants to merge 4 commits into
MetaMask:mainfrom
crazywriter1:fix/network-search-native-currency-typo
Open

fix: correct nativeCurrency typo in network search#45652
crazywriter1 wants to merge 4 commits into
MetaMask:mainfrom
crazywriter1:fix/network-search-native-currency-typo

Conversation

@crazywriter1

@crazywriter1 crazywriter1 commented Aug 20, 2026

Copy link
Copy Markdown

Description

  1. Reason: Network menu Fuse.js search used the key nativeCrrency instead of nativeCurrency, so searching by ticker (e.g. BNB, ETH) never matched.
  2. Solution: Correct the Fuse key to nativeCurrency and add a regression test that searches for BNB.

Changelog

CHANGELOG entry: Fixed network menu search by native currency symbol

Related issues

Fixes: N/A

Manual testing steps

  1. Open the network menu.
  2. Search BNB → BNB Smart Chain appears; unrelated networks are filtered out.
  3. Search ETH → Ethereum-related networks match.
  4. yarn test:unit ui/components/multichain/network-list-menu/network-list-menu.test.tsx --runInBand

Screenshots/Recordings

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
UI-only search typo fix with a regression test; no auth, data, or network-switching logic changes.

Overview
Fixes network menu search so queries like BNB or ETH match networks by their native currency ticker, not only name or chain ID.

The Fuse.js config used a misspelled field (nativeCrrency), so the nativeCurrency property was never searched. The key is corrected to nativeCurrency.

A unit test searches for BNB and asserts BNB Smart Chain stays visible while unrelated networks (e.g. Chain 5) are filtered out.

Reviewed by Cursor Bugbot for commit eb90832. Bugbot is set up for automated code reviews on this repo. Configure here.

Fuse.js was searching 'nativeCrrency' instead of 'nativeCurrency', so
ticker searches (e.g. BNB, ETH) in the network menu did not work.
@crazywriter1
crazywriter1 requested a review from a team as a code owner August 20, 2026 10:21
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@crazywriter1

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant