Skip to content

support only using saveAs and downloadUrl #9

Description

@kymppi

Currently there's in an edge case where the plugin download silently fails in the downloadPluginRecursive if multiple plugins with only saveAs and downloadUrl are defined.

Part of the problematic code:

	mapKey := plugin.GroupID + ":" + plugin.ArtifactID

	if version, ok := pluginMap[mapKey]; ok {
		if plugin.Version != version {
			return fmt.Errorf("version conflict (%s, %s) for %s", plugin.Version, version, mapKey)
		}

		return nil
	}

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions