feat(runtime): add bounded workspace file installer - #682
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an optional Linux workspace file installer for the pinned Codex executor. It streams up to 50 MiB through native process stdin, verifies a declared-length/SHA-256 frame, and replaces the destination entry without modifying other hard links. With concurrent workspace writers excluded by the caller, interrupted or invalid input preserves the old destination. Existing directory traversal is shared without changing listing behavior.
This adds the build artifact and documents its private contract. It does not enable Files.create, change default placement, or establish mutation recovery after transport/service loss. Preventing staging interference is an explicit prerequisite, not yet established for public uploads. Permission/I/O cleanup failures or forced termination may leave staging; missing commit receipts remain unknown.
Validation: executor tests, formatting, Clippy and release build; actual pinned Codex process RPC in the restricted Docker sandbox for binary/empty/overwrite/50 MiB files, hard-link and path isolation, and observed partial-write termination. This is a native mechanism check with synthetic bytes, not real-model/public SDK acceptance. Full
make checkpassed on candidate8efa6d3e (523.64s), using the existing pinned sqlc1.29.0 binary after the package proxy failed. Final candidate07e3635c adds only contract documentation to the tested candidate. A fresh independent full-diff review found no concrete in-scope issues; its separate build attempt was blocked by OpenSSL include configuration, so reviewer test execution is not claimed. No API/query/schema change; OpenAPI/sqlc regeneration is not applicable to this diff.