feat(agents-api): provision isolated Docker runtimes - #689
Merged
Merged
Conversation
SaladDay
marked this pull request as ready for review
September 17, 2026 23:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docker-managed Environments need a reusable Runtime allocation path instead of test-specific
docker runwiring. Add the five-operation Provider contract and a thin official Docker SDK adapter, plus a binary-bundle build for the colocated daemon, stock Codex and local filesystem helpers. Core and the existing execution/Files paths remain separate from provider initialization.Bootstrap injects the existing daemon credential profile into a private named volume before startup. Allocation references survive failures; repeated creation cannot replace credentials or retained history. Compute observations stay distinct from native readiness. Cleanup checks ownership and explicitly removes both the container and its named volumes; uncertain initialization commands require reclamation before reuse.
Validation:
make checkpassed (522 seconds).This delivers the Provider/Runtime foundation. Public hosted Session admission, durable provisioning/expiry integration and user-managed enrollment remain unfinished; no default route changes or complete protocol-compatibility claim. No API/schema changes; OpenAPI/sqlc regeneration is not applicable. The initial image's inaccessible requirements directory was corrected and the failed attempt retained.