Skip to content

Validate all internal documentation links - #103

Merged
charlesrhoward merged 2 commits into
mainfrom
codex/execution-link-near-miss-guard
Aug 13, 2026
Merged

Validate all internal documentation links#103
charlesrhoward merged 2 commits into
mainfrom
codex/execution-link-near-miss-guard

Conversation

@charlesrhoward

@charlesrhoward charlesrhoward commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Summary

Final reviewer follow-up for #100:

  • validate every Markdown and JSX internal docs link across every public MDX page
  • keep a two-entry allowlist for generated /llms.txt surfaces
  • support both single- and double-quoted JSX href attributes
  • assert that the scan checks real pages and routes, so it cannot pass vacuously

This catches renamed routes, near-miss typos, trailing-slash variants, and unrelated broken internal links instead of filtering them away.

Validation

  • pnpm lint
  • pnpm test (17 passed)
  • pnpm types:check
  • pnpm build

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@vercel

vercel Bot commented Aug 13, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
mogplex-docs Ready Ready Preview Aug 13, 2026 10:38pm

Request Review

@mogplex mogplex Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mogplex PR Review

Status: Attention needed

Test-only change that broadens the docs link checker from a two-route filter to all internal links across every public MDX page, with a two-entry allowlist for generated /llms.txt surfaces and a non-vacuity assertion. The implementation does what the PR description claims: I verified the /llms.txt links genuinely live in content/docs/index.mdx (justifying the allowlist), that section landing pages exist as real index.mdx files (so the broadened scan is satisfiable rather than vacuously structured), and that the single/double-quote JSX href backreference is correct. No security or correctness issues — approve-ready. Four suggestion-level robustness notes below (extractor over-matching images/code examples, a now-redundant sibling test, a weak vacuity floor, and undocumented extractor coverage boundaries); none should block the merge.

✅ APPROVE — the change is correct and well-scoped; the suggestions are follow-up polish, not blockers.

4 findings were added inline.

View check run

Comment thread tests/execution-environments-docs.test.mjs
Comment thread tests/execution-environments-docs.test.mjs
Comment thread tests/execution-environments-docs.test.mjs Outdated
Comment thread tests/execution-environments-docs.test.mjs Outdated
@charlesrhoward
charlesrhoward merged commit c1e836c into main Aug 13, 2026
7 checks passed
@charlesrhoward
charlesrhoward deleted the codex/execution-link-near-miss-guard branch August 13, 2026 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant