Validate all internal documentation links - #103
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Mogplex PR Review
Status: Attention needed
Test-only change that broadens the docs link checker from a two-route filter to all internal links across every public MDX page, with a two-entry allowlist for generated /llms.txt surfaces and a non-vacuity assertion. The implementation does what the PR description claims: I verified the /llms.txt links genuinely live in content/docs/index.mdx (justifying the allowlist), that section landing pages exist as real index.mdx files (so the broadened scan is satisfiable rather than vacuously structured), and that the single/double-quote JSX href backreference is correct. No security or correctness issues — approve-ready. Four suggestion-level robustness notes below (extractor over-matching images/code examples, a now-redundant sibling test, a weak vacuity floor, and undocumented extractor coverage boundaries); none should block the merge.
✅ APPROVE — the change is correct and well-scoped; the suggestions are follow-up polish, not blockers.
4 findings were added inline.
Summary
Final reviewer follow-up for #100:
/llms.txtsurfacesThis catches renamed routes, near-miss typos, trailing-slash variants, and unrelated broken internal links instead of filtering them away.
Validation
pnpm lintpnpm test(17 passed)pnpm types:checkpnpm buildNeed help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.