Skip to content

Evalaute DiffDock, Evo2, GenMol and MolMI on nvskills - #35

Open
ohadmo wants to merge 2 commits into
mainfrom
omosafi/first-nims
Open

ohadmo wants to merge 2 commits into
mainfrom
omosafi/first-nims

Conversation

@ohadmo

@ohadmo ohadmo commented Sep 19, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

Signed-off-by: Ohad Mosafi <omosafi@nvidia.com>
@ohadmo
ohadmo requested a review from trvachov September 19, 2026 00:17
@ohadmo ohadmo self-assigned this Sep 19, 2026
@ohadmo ohadmo changed the title evalaute DiffDock, Evo2, GenMol and MolMI on nvskills Evalaute DiffDock, Evo2, GenMol and MolMI on nvskills Sep 19, 2026
@ohadmo

ohadmo commented Sep 19, 2026

Copy link
Copy Markdown
Collaborator Author

@greptileai

@ohadmo

ohadmo commented Sep 19, 2026

Copy link
Copy Markdown
Collaborator Author

/nvskills-ci

@greptile-apps

greptile-apps Bot commented Sep 19, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with no outstanding correctness, security, synchronization, or artifact-integrity issues identified.

Summary

This PR updates four NIM skill evaluation definitions to the evaluator’s string assertion format, synchronizes those source changes into the distributed plugin payload, and attaches generated NVSkills benchmark, skill-card, and signature artifacts.

  • Converts DiffDock, Evo 2, GenMol, and MolMIM assertions without changing their evaluation requirements.
  • Keeps source and distributed skill copies aligned.
  • Publishes benchmark evidence and skill cards for all four skills.
  • Adds signatures whose resource manifests match the current payload bytes.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
    A[Source NIM skills] --> B[String-based evaluation assertions]
    B --> C[Generated plugin skill payload]
    C --> D[NVSkills evaluation]
    D --> E[BENCHMARK.md]
    D --> F[skill-card.md]
    C --> G[Byte-level signing]
    E --> G
    F --> G
    G --> H[skill.oms.sig]
Loading

Reviews (2) · Last reviewed commit: "Attach NVSkills validation signatures"

Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants