Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: NVIDIA-BioNeMo/bionemo-recipes/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
1a64e04 to
33b42a1
Compare
33b42a1 to
4bedef6
Compare
7ab3f0d to
ddfe217
Compare
cb3bb0b to
0d1d88b
Compare
…nes in the original implementation Signed-off-by: John St John <jstjohn@nvidia.com>
Signed-off-by: John St John <jstjohn@nvidia.com>
…osely related phages, as well as notes on genome architecture and linear genomes Signed-off-by: John St John <jstjohn@nvidia.com>
…in the skills Signed-off-by: John St John <jstjohn@nvidia.com>
…o the changes Signed-off-by: John St John <jstjohn@nvidia.com>
…te genomes naturally Signed-off-by: John St John <jstjohn@nvidia.com>
Signed-off-by: John St John <jstjohn@nvidia.com>
Signed-off-by: John St John <jstjohn@nvidia.com>
Signed-off-by: John St John <jstjohn@nvidia.com>
Signed-off-by: John St John <jstjohn@nvidia.com>
Signed-off-by: John St John <jstjohn@nvidia.com>
Signed-off-by: John St John <jstjohn@nvidia.com>
Signed-off-by: John St John <jstjohn@nvidia.com>
Signed-off-by: John St John <jstjohn@nvidia.com>
Signed-off-by: John St John <jstjohn@nvidia.com>
Signed-off-by: John St John <jstjohn@nvidia.com>
…iscrepency between AAI definition here and the paper, and fixed bugs with circular genome handling Signed-off-by: John St John <jstjohn@nvidia.com>
da2b22b to
130eea4
Compare
Signed-off-by: John St John <jstjohn@nvidia.com>
Signed-off-by: John St John <jstjohn@nvidia.com>
…ensitivity for partial hits Signed-off-by: John St John <jstjohn@nvidia.com>
Signed-off-by: John St John <jstjohn@nvidia.com>
…ternatives Replace annotation-label quotas with A/B/C/D/E/F/G/H/J slots and curated PHROG alternatives, including the viable alternate J. Document experimental rationale, conditional K/A* scope, and broader natural-homolog curation. Reuse one-to-one assignment and reward mean normalized function coverage; remove the MILP solver and redundant evidence-target knob. Align Arc, calibration, logging, docs, and skills, and reject unusable CSV evidence. Validation: 263 focused tests and 75 CPU environment tests passed; final Arc/skill rerun passed 61 tests. Five asset-dependent tests skipped. Prepared Arc wrapper matches direct scoring on 371 saved records, including 264 viable-control rotations at full credit. Generated mean changes from 0.364685 to 0.284122 as unsupported pilot-label substitutions lose credit; maximum remains 0.981046 and all 96 generated rows retain positive reward.
…synteny Signed-off-by: John St John <jstjohn@nvidia.com>
Signed-off-by: John St John <jstjohn@nvidia.com>
Signed-off-by: John St John <jstjohn@nvidia.com>
Signed-off-by: John St John <jstjohn@nvidia.com>
Signed-off-by: John St John <jstjohn@nvidia.com>
Run the protein createdb/align/convertalis stages with a private NUL-terminated exhaustive candidate database. Preserve target indices, alignment settings, thresholds, error propagation and scoring formulas. Regression coverage for page-aligned indices and native failure paths. Qualified 20 exact-image ARM runs on the retained 5199-ORF batch with identical 1152-row outputs, plus exact full-scorer objective-vector agreement on WT and negative/mixed controls.
…y train masking when no phylo tags are present Signed-off-by: John St John <jstjohn@nvidia.com>
…hich we primarily use Signed-off-by: John St John <jstjohn@nvidia.com>
Signed-off-by: John St John <jstjohn@nvidia.com>
Signed-off-by: John St John <jstjohn@nvidia.com>
Signed-off-by: John St John <jstjohn@nvidia.com>
…ent that was removed Signed-off-by: John St John <jstjohn@nvidia.com>
Signed-off-by: John St John <jstjohn@nvidia.com>
…ng the accessory gene criteria Signed-off-by: John St John <jstjohn@nvidia.com>
Description
Addresses the following
Usage
Type of changes
CI Pipeline Configuration
Configure CI behavior by applying the relevant labels. By default, only basic unit tests are run.
Unit tests marked as
@pytest.mark.multi_gpuor@pytest.mark.distributedare not run in the PR pipeline.For more details, see CONTRIBUTING
Note
By default, only basic unit tests are run. Add appropriate labels to enable an additional test coverage.
Authorizing CI Runs
We use copy-pr-bot to manage authorization of CI
runs on NVIDIA's compute resources.
automatically be copied to a pull-request/ prefixed branch in the source repository (e.g. pull-request/123)
/ok to testcomment on the pull request to trigger CI. This will need to be done for each new commit.Triggering Code Rabbit AI Review
To trigger a code review from code rabbit, comment on a pull request with one of these commands:
See https://docs.coderabbit.ai/reference/review-commands for a full list of commands.
Pre-submit Checklist