Conversation
Signed-off-by: VishnuR23 <vishnurajeev2345@gmail.com>
VishnuR23
requested review from
jstjohn,
jwilber,
pstjohn,
savitha-eng and
trvachov
as code owners
September 21, 2026 06:16
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: NVIDIA-BioNeMo/bionemo-recipes/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
run_subprocess_safelywaits until the child has exited before callingwait(timeout=...), so its timeout never limits a running command. A command sleeping for 0.5 seconds with a 0.05-second timeout returns success after roughly 0.58 seconds. Reading a partial line can also block the main loop, and the baseline stalled while draining large stdout/stderr output.Drain stdout and stderr concurrently with reader threads while the main thread calls
wait(timeout=...). On timeout, kill and reap the child, finish collecting its output, and return the existing timeout error structure with partial output. Preserve live output and the existing success/nonzero-exit/not-found result formats. Regenerate the shared copies in Eden and phage recipes.Type of changes
Validation