Skip to content

Atom-Atom Path Fingerprints + DISE clustering - #303

Open
scal444 wants to merge 13 commits into
NVIDIA-BioNeMo:mainfrom
scal444:codex/aap-rdkit-reference-workflow
Open

scal444 wants to merge 13 commits into
NVIDIA-BioNeMo:mainfrom
scal444:codex/aap-rdkit-reference-workflow

Conversation

@scal444

@scal444 scal444 commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@scal444

scal444 commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile-apps please review.

@greptile-apps

greptile-apps Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge because no new actionable correctness, security, build, or repository-rule issue remains.

Summary

This PR adds GPU-backed Atom-Atom Path similarity and directed sphere-exclusion clustering, including Python bindings, result modes, validation tests, documentation, and comparative benchmark support.

  • Implements AAP descriptor construction and GPU similarity evaluation.
  • Adds first-match and nearest-centroid DISE clustering with host and device result forms.
  • Adds CSV benchmark loading with preserved molecule properties and reference-workflow comparisons.
  • Integrates the native AAP library into the Python extension and API documentation.

Reviews (4) · Last reviewed commit: "Merge remote-tracking branch 'official/m..."

Comment thread src/aap.cu
Comment thread benchmarks/aap_clustering_bench.py Outdated
@scal444

scal444 commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile-apps review and go back to previous comments

@scal444
scal444 marked this pull request as ready for review September 14, 2026 18:44
@scal444
scal444 requested a review from evasnow1992 September 14, 2026 18:44

@evasnow1992 evasnow1992 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this new similarity + clustering workflow. Implementation is clean and valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants