Skip to content

Enable a subset of cppcoreguidelines checks - #316

Open
scal444 wants to merge 4 commits into
NVIDIA-BioNeMo:mainfrom
scal444:codex/clang-cppcoreguidelines
Open

scal444 wants to merge 4 commits into
NVIDIA-BioNeMo:mainfrom
scal444:codex/clang-cppcoreguidelines

Conversation

@scal444

@scal444 scal444 commented Sep 19, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@greptile-apps

greptile-apps Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge because the previously identified lint-breaking check is now excluded and no new issues were found.

Summary

This PR enables a selected subset of cppcoreguidelines clang-tidy checks while excluding checks incompatible with existing CUDA, C, RDKit, numerical, and performance-sensitive code.

  • The update since the previous review excludes cppcoreguidelines-pro-type-union-access.
  • This resolves the previously reported clang-tidy failure involving intentional union access.

Reviews (2) · Last reviewed commit: "Exclude intentional CUDA union access"

Comment thread .clang-tidy
@scal444
scal444 requested a review from evasnow1992 September 19, 2026 14:05
@scal444

scal444 commented Sep 19, 2026

Copy link
Copy Markdown
Collaborator Author

Towards #308

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant