Forward-merge release/0.4 into main - #349
Merged
Merged
Conversation
#### Overview Keep the NOOA 0.0.10 adapter working with Relay 0.9.3. NOOA's tool middleware returns a raw JSON-compatible value, while Relay 0.9 requires the callback to return `ToolExecutionResult`. This adds a Fabric-owned compatibility installer until NOOA supports the Relay version used by Fabric. - [x] I confirm this contribution is my own work, or I have the right to submit it under this project's license. - [x] I searched existing issues and open pull requests, and this does not duplicate existing work. #### Details - Register NOOA's agent and LLM middleware with a local tool middleware that preserves NOOA's argument propagation and result extraction, then wraps the tool callback payload in `ToolExecutionResult`. Pass `tool_call_id` to Relay's dedicated parameter and return short-circuit execution intercept results through NOOA's `ExecutionResult`. - Exercise the compatibility callback with a list result in the Relay subprocess e2e fixture, and cover callback results, intercepted arguments, rejection, exception propagation, and installer cleanup in direct tests. - Keep the shim isolated in `relay_compat.py` and note its removal above the NOOA version pins (issue #347). - Breaking changes: none. #### Validation - `uvx --offline ruff format` and `uvx --offline ruff check` on changed Python files: passed. - Focused NOOA adapter, direct compatibility, and Relay subprocess e2e tests: 62 passed, including a real Relay 0.9.3 short-circuit execution intercept regression. - `just test-python`: 1,600 passed, 90 skipped, 1 unrelated failure in `tests/e2e/test_opencode.py` because `@opencode/core@2.0.3` and `@opencode/sdk@2.0.3` are not installed in this checkout. - A standalone Harbor e2e invocation initially failed because this checkout's prior environment lacked `harbor.environments`; `just test-python` synced the environment and the Harbor NOOA e2e then passed. - The NOOA manifest parses with both version pins unchanged; `git diff --check` and the Rust attribution hook passed. - The license diff and Python attribution hook were attempted but did not finish while downloading locked Python artifact metadata. No dependencies or lock files changed. #### Where should the reviewer start? Start with `adapters/python/nooa/src/nemo_fabric_adapters/nooa/relay_compat.py`, `tests/adapters/test_nooa_relay_compat.py`, and `tests/e2e/test_nooa.py`. The latter now invokes the compatibility middleware through the subprocess fixture with a list tool result. #### Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to) - Relates to #347 - Related Helix failure: https://github.com/NVIDIA-NeMo/nemo-helix/actions/runs/36895120854/job/110480287974 ## Summary by CodeRabbit * **Compatibility** * Improved compatibility between NOOA and Relay 0.9 for agent, language-model, and Python tool interactions. * Python tool calls support passing code and optional call details, and return results in Relay’s expected format. * Relay can intercept and customize Python tool execution, and the integration can be uninstalled. * Calls rejected before tool execution return an error, and execution errors are propagated. Authors: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) Approvers: - Yuchen Zhang (https://github.com/yczhang-nv) - Maryam Najafian (https://github.com/mnajafian-nv) URL: #348
Author
|
SUCCESS - forward-merge complete. |
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: NVIDIA/NeMo-Fabric/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
sara-tadayon-nv
had a problem deploying
to
npmjs
October 1, 2026 21:43 — with 
GitHub Actions
Failure
GitHub Actions
Failure
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-merge triggered by push to release/0.4 that creates a PR to keep main up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge. See forward-merger docs for more info.