fix(parse): reject unsupported local models - #2585
Merged
Merged
Conversation
Contributor
Greptile SummaryThe PR prevents unsupported local Nemotron Parse model IDs from being silently accepted while preserving explicitly configured remote model contracts.
|
| Filename | Overview |
|---|---|
| docs/docs/extraction/nemo-retriever-api-reference.md | Documents the supported local Parse model, remote-model configuration, and correct public ValidationError contract. |
| nemo_retriever/src/nemo_retriever/common/params/models.py | Rejects non-default Parse model IDs only when extraction is configured locally. |
| nemo_retriever/src/nemo_retriever/common/params/utils.py | Introduces the canonical supported local Nemotron Parse model identifier. |
| nemo_retriever/tests/test_params_models.py | Covers unsupported local model rejection and remote model acceptance through both endpoint fields. |
Reviews (2): Last reviewed commit: "docs(parse): correct validation exceptio..." | Re-trigger Greptile
jperez999
approved these changes
Aug 26, 2026
This was referenced Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This prevents a Parse 2.0 request from being silently ignored while the local actor loads Parse v1.2.
Validation