[PyTorch] Document heterogeneous quantization recipes - #3336
Conversation
Signed-off-by: Evgeny <etsykunov@nvidia.com>
Greptile SummaryThis PR documents heterogeneous PyTorch quantization recipes and corrects the example’s wgrad provenance description.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains; the previously reported wgrad provenance discrepancy is corrected and the current documentation matches the quantizer configuration and Linear backward path. Important Files Changed
Reviews (3): Last reviewed commit: "resolve comments" | Re-trigger Greptile |
…/pytorch_fine_grained_quantization_example.py Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> Signed-off-by: Evgeny Tsykunov <e.tsykunov@gmail.com>
|
First observation: this part is done in very different style than the rest of the Features section.
|
|
First observation: when I start reading it there is a lot of defensive text about experimental API and some philosophical section Configuration readiness. I think it would be great to start, after short introduction with short example what we can do - using more than one recipe with the picture with some code snippet. Then we can elaborate on the API in more detail. |
There was a problem hiding this comment.
I think this is too long - we can have something before #START_FINE_GRAINED_QUANTIZATION_EXAMPLE or in different files like model building and require_supported_hardware() . BTW see how we deal with support hardware in boxes in the other recipes docs.
|
Note that we can split this: short docs in Features and tutorial in Tutorials like we have done with gemm profiling tutorial. |
Signed-off-by: Evgeny <etsykunov@nvidia.com>
|
@pggPL thanks for the comments, I applied all your suggestions |
Description
Document heterogeneous quantization recipes.
This is enabled after hybrid quantization support #2817 is merged
Type of change
Changes
Please list the changes introduced in this PR:
Checklist: