Skip to content

fix: add pod UID to DRA-attributed metrics - #738

Closed
git-jxj wants to merge 1 commit into
NVIDIA:mainfrom
git-jxj:git-jxj/fix-dra-pod-uid
Closed

git-jxj wants to merge 1 commit into
NVIDIA:mainfrom
git-jxj:git-jxj/fix-dra-pod-uid

Conversation

@git-jxj

@git-jxj git-jxj commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Description

Honor KubernetesEnablePodUID in the DRA attribution path, matching the existing device-plugin path. DRA-attributed metrics now include the existing pod_uid attribute when the option is enabled.

The regression test exercises the full fake PodResources and DRA ResourceSlice mapping path for a MIG metric and verifies the UID alongside the existing pod and DRA attributes.

Testing

  • go test ./internal/pkg/transformation -run "^TestPodMapperProcessAddsDRAAttributesForMIGMetric$" -count=1
  • go test ./internal/pkg/transformation -count=1
  • CPU-safe repository package sweep excluding tests/k8s, integration_test, and nvmlprovider
  • make lint LINT_BASE_REV=origin/main
  • make check-fmt

A direct go test ./... -short also reached the repository-wide packages; only the existing GPU/DCGM-backed packages failed because this host lacks libdcgm.so.4 and has no matching NVML driver.

Fixes #718

Signed-off-by: git-jxj <65210887+git-jxj@users.noreply.github.com>
@git-jxj

git-jxj commented Sep 16, 2026

Copy link
Copy Markdown
Contributor Author

Current head 6b375ca has not run the Go workflow: the run is action_required pending outside-contributor approval. Could a maintainer approve this workflow run so CI can validate the change? https://github.com/NVIDIA/dcgm-exporter/actions/runs/34957252600

@nccurry

nccurry commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator

This should be fixed in 4.8.4. Closing. Please re-open or open a new issue or PR if you find issues.

@nccurry nccurry closed this Sep 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

KUBERNETES_ENABLE_POD_UID does not add pod UID label in DRA-attributed metrics

2 participants