Conversation
Signed-off-by: git-jxj <65210887+git-jxj@users.noreply.github.com>
Contributor
Author
|
Current head 6b375ca has not run the Go workflow: the run is action_required pending outside-contributor approval. Could a maintainer approve this workflow run so CI can validate the change? https://github.com/NVIDIA/dcgm-exporter/actions/runs/34957252600 |
Collaborator
|
This should be fixed in 4.8.4. Closing. Please re-open or open a new issue or PR if you find issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Honor
KubernetesEnablePodUIDin the DRA attribution path, matching the existing device-plugin path. DRA-attributed metrics now include the existingpod_uidattribute when the option is enabled.The regression test exercises the full fake PodResources and DRA ResourceSlice mapping path for a MIG metric and verifies the UID alongside the existing pod and DRA attributes.
Testing
go test ./internal/pkg/transformation -run "^TestPodMapperProcessAddsDRAAttributesForMIGMetric$" -count=1go test ./internal/pkg/transformation -count=1tests/k8s,integration_test, andnvmlprovidermake lint LINT_BASE_REV=origin/mainmake check-fmtA direct
go test ./... -shortalso reached the repository-wide packages; only the existing GPU/DCGM-backed packages failed because this host lackslibdcgm.so.4and has no matching NVML driver.Fixes #718