Skip to content

fix(docker): default Accept header of requests for manifest results in 404 error #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vertsineu wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(docker): default Accept header of requests for manifest results in 404 error #273

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4dac1d
fix: add Accept header for HEAD requests
Vertsineu Aug 4, 2026
7a0d466
fix: further add Accept headers for requests to docker registry
Vertsineu Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions src/docker.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,17 @@ else
readonly curl_opts=("--proto" "=https" "--retry" "${ENROOT_TRANSFER_RETRIES}" "--connect-timeout" "${ENROOT_CONNECT_TIMEOUT}" "--max-time" "${ENROOT_TRANSFER_TIMEOUT}" "-SsL")
fi

readonly docker_accept_manifest_list="Accept: application/vnd.docker.distribution.manifest.list.v2+json, application/vnd.oci.image.index.v1+json"
readonly docker_accept_manifest="Accept: application/vnd.docker.distribution.manifest.v2+json, application/vnd.oci.image.manifest.v1+json"
readonly docker_accept_manifests="${docker_accept_manifest_list}, ${docker_accept_manifest#Accept: }"

docker::_authenticate() {
local -r user="$1" registry="$2" url="$3"
local realm= token= req_params=() resp_headers=

# Query the registry to see if we're authorized.
common::log INFO "Querying registry for permission grant"
resp_headers=$(CURL_IGNORE=401 common::curl "${curl_opts[@]}" -I -- "${url}")
resp_headers=$(CURL_IGNORE=401 common::curl "${curl_opts[@]}" -I -H "${docker_accept_manifests}" -- "${url}")

# If we don't need to authenticate, we're done.
if ! grep -qi '^www-authenticate:' <<< "${resp_headers}"; then
Expand Down Expand Up @@ -73,7 +77,7 @@ docker::_authenticate() {
;;
Basic)
# Check that we have valid credentials and save them if successful.
common::curl "${curl_opts[@]}" -G -v ${req_params[@]+"${req_params[@]}"} -- "${url}" 2>&1 > /dev/null \
common::curl "${curl_opts[@]}" -G -v -H "${docker_accept_manifests}" ${req_params[@]+"${req_params[@]}"} -- "${url}" 2>&1 > /dev/null \
| awk '/Authorization: Basic/ { sub(/\r/, "", $4); print $4 }' \
| common::read -r token
;;
Expand Down Expand Up @@ -137,8 +141,6 @@ docker::_download() {

local req_params=() layers=() layer_media_types=() missing_digests=() missing_media_types=()
local manifest= config= digest= media_type= idx=
local accept_manifest_list=("-H" "Accept: application/vnd.docker.distribution.manifest.list.v2+json, application/vnd.oci.image.index.v1+json")
local accept_manifest=("-H" "Accept: application/vnd.docker.distribution.manifest.v2+json, application/vnd.oci.image.manifest.v1+json")
local url_manifest="${curl_proto}://${registry}/v2/${image}/manifests/${tag}"
local -r url_digest="${curl_proto}://${registry}/v2/${image}/blobs/"

Expand All @@ -150,7 +152,7 @@ docker::_download() {

# Attempt to use the image manifest list if it exists.
common::log INFO "Fetching image manifest list"
CURL_IGNORE="401 404" common::curl "${curl_opts[@]}" "${accept_manifest_list[@]}" "${req_params[@]}" -- "${url_manifest}" \
CURL_IGNORE="401 404" common::curl "${curl_opts[@]}" -H "${docker_accept_manifest_list}" "${req_params[@]}" -- "${url_manifest}" \
| common::jq -R -s -r "(fromjson | .manifests[] | select(.platform.architecture == \"${arch}\") | .digest)? // empty" \
| common::read -r manifest

Expand All @@ -160,7 +162,7 @@ docker::_download() {

# Fetch the image manifest.
common::log INFO "Fetching image manifest"
common::curl "${curl_opts[@]}" "${accept_manifest[@]}" "${req_params[@]}" -- "${url_manifest}" \
common::curl "${curl_opts[@]}" -H "${docker_accept_manifest}" "${req_params[@]}" -- "${url_manifest}" \
| common::jq -r '(.config.digest | ltrimstr("sha256:"))? // empty, ([.layers[].digest | ltrimstr("sha256:")] | reverse | @tsv)?, ([.layers[].mediaType] | reverse | @tsv)?' \
| { common::read -r config; IFS=$'\t' common::read -r -a layers; IFS=$'\t' common::read -r -a layer_media_types; }

Expand Down Expand Up @@ -417,8 +419,6 @@ docker::digest() (
fi

local req_params=() manifest= manifest_digest=
local accept_manifest_list=("-H" "Accept: application/vnd.docker.distribution.manifest.list.v2+json, application/vnd.oci.image.index.v1+json")
local accept_manifest=("-H" "Accept: application/vnd.docker.distribution.manifest.v2+json, application/vnd.oci.image.manifest.v1+json")
local url_manifest="${curl_proto}://${registry}/v2/${image}/manifests/${tag}"

# Authenticate with the registry.
Expand All @@ -429,7 +429,7 @@ docker::digest() (
fi

# Attempt to use the image manifest list if it exists.
CURL_IGNORE="401 404" common::curl "${curl_opts[@]}" "${accept_manifest_list[@]}" "${req_params[@]}" -- "${url_manifest}" \
CURL_IGNORE="401 404" common::curl "${curl_opts[@]}" -H "${docker_accept_manifest_list}" "${req_params[@]}" -- "${url_manifest}" \
| common::jq -R -s -r "(fromjson | .manifests[] | select(.platform.architecture == \"${arch}\") | .digest)? // empty" \
| common::read -r manifest

Expand All @@ -438,7 +438,7 @@ docker::digest() (
fi

# Fetch the image manifest and get the digest from response headers.
manifest_digest=$(common::curl "${curl_opts[@]}" "${accept_manifest[@]}" "${req_params[@]}" -I -- "${url_manifest}" \
manifest_digest=$(common::curl "${curl_opts[@]}" -H "${docker_accept_manifest}" "${req_params[@]}" -I -- "${url_manifest}" \
| grep -i '^docker-content-digest:' \
| awk '{print $2}' \
| tr -d '\r')
Expand Down