Skip to content

fix(data): ImageFilelist does not join root with flist path (+3 more) - #82

Open
andrewwhitecdw wants to merge 1 commit into
NVlabs:masterfrom
andrewwhitecdw:bugfix/data-assorted-bd46cc36
Open

fix(data): ImageFilelist does not join root with flist path (+3 more)#82
andrewwhitecdw wants to merge 1 commit into
NVlabs:masterfrom
andrewwhitecdw:bugfix/data-assorted-bd46cc36

Conversation

@andrewwhitecdw

@andrewwhitecdw andrewwhitecdw commented Jul 27, 2026

Copy link
Copy Markdown

Small fixes in data.py:

fix: ImageFilelist does not join root with flist path

Fix: Replace:

class ImageFilelist(data.Dataset):
    def __init__(self, root, flist, transform=None,
                 flist_reader=default_flist_reader, loader=default_loader):
        self.root = root
        self.imlist = flist_reader(flist)

with:

class ImageFilelist(data.Dataset):
    def __init__(self, root, flist, transform=None,
                 flist_reader=default_flist_reader, loader=default_loader):
        self.root = root
        self.imlist = flist_reader(os.path.join(self.root, flist))

fix: default_flist_reader docstring mismatches implementation

Fix: Replace:

def default_flist_reader(flist):
    """
    flist format: impath label\nimpath label\n ...(same to caffe's filelist)
    """
    imlist = []

with:

def default_flist_reader(flist):
    """
    flist format: impath\nimpath\n ...
    """
    imlist = []

fix: default_flist_reader keeps label as part of image path

Fix: Replace:

    imlist = []
    with open(flist, 'r') as rf:
        for line in rf.readlines():
            impath = line.strip()
            imlist.append(impath)

    return imlist

with:

    imlist = []
    with open(flist, 'r') as rf:
        for line in rf.readlines():
            line = line.strip()
            if not line:
                continue
            impath = line.split()[0]
            imlist.append(impath)

    return imlist

fix: ImageFilelist ignores root when reading flist

Fix: Replace:

    def __init__(self, root, flist, transform=None,
                 flist_reader=default_flist_reader, loader=default_loader):
        self.root = root
        self.imlist = flist_reader(flist)
        self.transform = transform
        self.loader = loader

with:

    def __init__(self, root, flist, transform=None,
                 flist_reader=default_flist_reader, loader=default_loader):
        self.root = root
        self.imlist = flist_reader(os.path.join(self.root, flist))
        self.transform = transform
        self.loader = loader

Files changed

  • data.py

@andrewwhitecdw
andrewwhitecdw marked this pull request as ready for review August 3, 2026 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant