Skip to content

fix(show-smooth): image and gif saved to cwd, ignoring (+1 more) - #97

Open
andrewwhitecdw wants to merge 2 commits into
NVlabs:masterfrom
andrewwhitecdw:bugfix/show-smooth-assorted-72e767b3
Open

fix(show-smooth): image and gif saved to cwd, ignoring (+1 more)#97
andrewwhitecdw wants to merge 2 commits into
NVlabs:masterfrom
andrewwhitecdw:bugfix/show-smooth-assorted-72e767b3

Conversation

@andrewwhitecdw

@andrewwhitecdw andrewwhitecdw commented Jul 27, 2026

Copy link
Copy Markdown

Small fixes in visual_tools/show_smooth.py:

fix: image and gif saved to cwd, ignoring output_folder

Fix: Replace:

pic.save('smooth.jpg')

# save gif
imageio.mimsave('./smooth.gif', gif)

with:

pic.save(os.path.join(opts.output_folder, 'smooth.jpg'))

# save gif
imageio.mimsave(os.path.join(opts.output_folder, 'smooth.gif'), gif)

fix: GIF writer receives float images instead of uint8

Fix: Replace:

# save gif
imageio.mimsave('./smooth.gif', gif)

with:

# save gif
imageio.mimsave('./smooth.gif', [frame.astype(np.uint8) for frame in gif])

Files changed

  • visual_tools/show_smooth.py

andrewwhitecdw and others added 2 commits July 27, 2026 07:25
Auditor: The diff addresses only the output_folder path change but omits the stated uint8 conversion for GIF frames, leaving the second bug unfixed. The proposed change is therefore incomplete relative to its own description.
@andrewwhitecdw
andrewwhitecdw marked this pull request as ready for review August 3, 2026 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant