fix(show-smooth-structure): image and gif saved to cwd (+1 more) - #98
Open
andrewwhitecdw wants to merge 2 commits into
Open
fix(show-smooth-structure): image and gif saved to cwd (+1 more)#98andrewwhitecdw wants to merge 2 commits into
andrewwhitecdw wants to merge 2 commits into
Conversation
Auditor: The diff only fixes the output path for the JPG and GIF, but the second stated problem (GIF frames are floats instead of uint8) is not addressed. The `imageio.mimsave` call still passes `gif` unchanged. The PR is incomplete relative to its own description.
andrewwhitecdw
marked this pull request as ready for review
August 3, 2026 22:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small fixes in
visual_tools/show_smooth_structure.py:fix: image and gif saved to cwd, ignoring output_folder
Fix: Replace:
with:
fix: GIF writer receives float images instead of uint8
Fix: Replace:
with:
Files changed
visual_tools/show_smooth_structure.py