Record 1.0.0 in each package's own changelog - #85
Merged
Conversation
Every package carries its own CHANGELOG.md and only the repository one was moved to 1.0.0, so all three published packages shipped a changelog whose newest entry was 0.7.0. pana docks five points for exactly that, and it is visible on all three pub.dev pages. Each entry says what changed in that package rather than repeating the repository record, which is what these files are for: fluttorch gets the manifest parts and the schema version, fluttorch_test gets the measured bounds and the rename, and fluttorch_gen gets the honest note that nothing about its output changed and what changed is that a second output finally exercised it. The published 1.0.0 keeps the deduction. pub.dev does not allow a version to be overwritten, so this lands with whatever ships next.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pana on pub.dev:
CHANGELOG.md does not contain reference to the current version ("1.0.0"), 0/5 points, on all three published packages.Every package carries its own
CHANGELOG.mdand only the repository one was moved to1.0.0, sofluttorch,fluttorch_genandfluttorch_testeach shipped a changelog whose newest entry was0.7.0.Each entry says what changed in that package rather than repeating the repository record, which is what these files exist for:
fluttorch:BundlePart,bundleDigestOf, thepartsargument,BundlePartMissingException, andcurrentSchemaVersionrising to 2.fluttorch_test:boundFor, the measured bounds and which models they came from,ParityMatrix.precisionOf,DirectoryGoldenBundle.parts().fluttorch_gen: nothing about its output changed. What changed is that a model with a second output finally exercised the accessor that reads_tensors[1], which had been written and never run. Saying so is more useful than an empty entry.What this does not fix
The published
1.0.0keeps the deduction. pub.dev does not allow a version to be overwritten, so the score moves with whatever ships next.