Allow Percent heating efficiency for furnaces/boilers

[shorowit]

Pull Request Description

Closes #2243. For furnaces/boilers, allows heating efficiency with units of "Percent" as an alternative to "AFUE"; the two units are modeled identically.

Checklist

Not all may apply:

• Schematron validator (EPvalidator.sch) has been updated
• Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
• Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
• Documentation has been updated
• Changelog has been updated
• openstudio tasks.rb update_measures has been run
• No unexpected changes to simulation results of sample files

[Copilot]

🟡 Not ready to approve

Builder choices remain labeled AFUE while electric selections are silently serialized as Percent.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.

Pull request overview

Adds Percent efficiency support for furnaces and boilers while preserving AFUE compatibility.

Changes:

• Extends validation, modeling, and defaults to accept Percent efficiency.
• Updates electric HVAC samples and tests.
• Updates documentation, changelog, and measure metadata.

File summaries

File	Description
workflow/tests/HERS_HVAC/HVAC2e.xml	Uses Percent for electric heating.
workflow/sample_files/base-hvac-wall-furnace-elec-only.xml	Updates electric wall furnace units.
workflow/sample_files/base-hvac-multiple.xml	Updates electric furnace and boiler units.
workflow/sample_files/base-hvac-furnace-elec-only.xml	Updates electric furnace units.
workflow/sample_files/base-hvac-furnace-elec-central-ac-1-speed.xml	Updates combined-system furnace units.
workflow/sample_files/base-hvac-boiler-elec-only.xml	Updates electric boiler units.
tasks.rb	Generates Percent-based electric systems.
HPXMLtoOpenStudio/tests/test_validation.rb	Updates efficiency warning coverage.
HPXMLtoOpenStudio/tests/test_hvac.rb	Verifies Percent-based modeling.
HPXMLtoOpenStudio/tests/test_defaults.rb	Uses Percent in an electric furnace fixture.
HPXMLtoOpenStudio/resources/hvac.rb	Models AFUE and Percent identically.
HPXMLtoOpenStudio/resources/hpxml_schematron/EPvalidator.sch	Permits and validates Percent values.
HPXMLtoOpenStudio/resources/defaults.rb	Handles either efficiency representation.
HPXMLtoOpenStudio/measure.xml	Refreshes measure metadata and checksums.
docs/source/workflow_inputs.rst	Documents both supported units.
Changelog.md	Records the new capability.
BuildResidentialHPXML/measure.xml	Refreshes builder metadata.
BuildResidentialHPXML/measure.rb	Emits Percent for electric furnaces and boilers.

Review details

Suppressed comments (1)

BuildResidentialHPXML/measure.rb:2727

• The same unit mismatch affects the secondary-system API: every furnace/boiler choice in BuildResidentialHPXML/resources/options/hvac_heating_system_2.tsv is named AFUE, but choosing electricity now serializes that selected value as Percent. Please expose a unit-neutral or explicit Percent choice and verify the secondary electric-system output unit in the builder test.

      if args[:hvac_heating_system_2_fuel_type] == HPXML::FuelTypeElectricity
        # AFUE does not apply to electricity
        heating_efficiency_percent = args[:hvac_heating_system_2_heating_efficiency]

• Files reviewed: 18/18 changed files
• Comments generated: 1
• Review effort level: Balanced

We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.