Appliance label warnings - #2252
Merged
Merged
Conversation
…nputs (e.g., `LabelElectricRate` and `LabelGasRate`).
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Schematron warnings for atypical appliance EnergyGuide label values.
Changes:
- Adds warning thresholds for clothes washers and dishwashers.
- Adds validation tests and updates generated metadata.
- Documents the validation enhancement.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
EPvalidator.sch |
Defines appliance label warnings. |
test_validation.rb |
Tests warning generation. |
measure.xml |
Updates checksums and version metadata. |
Changelog.md |
Records the enhancement. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Closes #2251. Adds min/max value warnings for clothes washer and dishwasher label inputs (e.g.,
LabelElectricRateandLabelGasRate). Decided to use warnings instead of errors to ensure we don't accidentally limit any real products (today or in the future).Checklist
Not all may apply:
EPvalidator.sch) has been updatedopenstudio tasks.rb update_hpxmls)HPXMLtoOpenStudio/tests/test*.rband/orworkflow/tests/test*.rb)openstudio tasks.rb update_measureshas been run