feat: the agent names the findings behind an alert, and alerted pull requests sit at the top of the inbox - #106
Merged
Merged
Conversation
…requests sit at the top of the inbox The preparing agent can now print an ALERT-FINDINGS line beside its ALERT, naming the inline findings that make the pull request one to look at now — by the thread ids `diffity agent comment` printed, as 8-character prefixes or full uuids, spaced or comma-separated. They are kept on the row in a new `alert_findings` column, and a pull request with an alert is listed under a new Alerted section above Ready, on the page and in `diffity inbox status`, most recently prepared first. A posted review still takes the row to Handled, and an alert notifies from either list. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Bwp5QefjsjMFeq6CK6cT6w
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The preparing agent can now say which findings make a pull request an alert, and the alerted ones are listed first.
alertWhenset, the agent is asked for an optionalALERT-FINDINGS: <thread id> <thread id> …line beside itsALERT:— the idsdiffity agent commentprinted (Created thread cf15e689), as 8-character prefixes or full uuids, spaced or comma-separated.verdictOfreturnsalertFindings; the lastALERT/ALERT-FINDINGSbeforePREPAREDcount, in either order, and findings without an alert are ignored.alert_findings TEXToninbox_prs(JSON, migrated onto an older table, a bad value reads as none) andInboxPr.alertFindings. AnalertPathsalert names none — only the agent names findings.InboxView.alerted— the prepared or stale rows with an alert, most recently prepared first;readyis the rest, smallest first as before. New Alerted section above Ready on the page and indiffity inbox status, same card plus the alert text and "2 findings" on the meta line. A review the reviewer has posted still goes to Handled rather than staying alerted, and the tab notification fires from either list.Try it
npm run build node packages/cli/dist/index.js inbox status # Alerted above Ready to reviewPart of #101 — PR B has the daemon post those findings to the pull request.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Bwp5QefjsjMFeq6CK6cT6w