feat: with postAlerts on, the daemon posts the findings behind an alert to the pull request, prefixed, and keeps the pull request as the reviewer's - #107
Merged
Conversation
…rt to the pull request, prefixed, and keeps the pull request as the reviewer's Turn `postAlerts` on and the daemon puts the findings the agent named as the reason for an alert on the pull request itself, the moment the review is prepared: one COMMENT review in the reviewer's name, its body the alert reason and each inline comment opening with `postPrefix`, at most once per head. A path alert posts nothing, and the post is the daemon's own `gh` call after the agent has finished — the agent still never gets the reviewer's credentials. The posted findings are marked as sent in the prepared session (a hidden `agent mark-posted`), travel that way in the bundle, and are left out of the reviewer's own submit. A submitted review withdraws the review request, so a row the daemon posted to is reconciled as though the search still listed it: it stays openable, a push re-prepares and posts again at the new head, a dismissal holds, and the reviewer's own review moves it to Handled. A post that fails is logged and leaves the review prepared with its alert. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Bwp5QefjsjMFeq6CK6cT6w
…wer but not the pull request The reason alone goes to the author only for an alert that named no findings, which is all there is to say about it. When the agent named findings and none of them is open by the time the review goes out — the checking pass dismissed them — nothing is posted: the pull request would otherwise carry an alert whose whole basis has just been rejected. The row still shows the alert, so the reviewer decides what to do with it. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Bwp5QefjsjMFeq6CK6cT6w
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR B of #101. With the new
postAlertssetting on, the daemon posts the findings the agent named behind anALERTto the pull request as soon as the review is prepared — oneCOMMENTreview in your name, its body the alert reason and every inline comment opening withpostPrefix, at most once per head. A path alert (alertPaths) posts nothing. The post is the daemon's ownghcall after the agent has finished; the agent still never gets your credentials.Those findings are marked as sent in the prepared session (new hidden
diffity agent mark-posted), travel that way in the bundle (BundleThread.posted), and so are left out of your own submit. A submitted review withdraws the review request, so a row the daemon posted to is reconciled as if the search still listed it: it stays openable, a push re-prepares and posts again at the new head, a dismissal holds, and your own review moves it to Handled. A failed post is logged and leaves the review prepared with its alert showing.Also:
auto_posted_*oninbox_prs, the posted card says "posted to the pull request · HH:MM" with the review URL in its hover, the tab notification says so too, and the README's "never posts" paragraph is rewritten.To try it: turn on "Also post the alert findings to the pull request" in the inbox page's Settings, with words in "Notify me if", and bump a pull request the agent will flag.
Closes #101
🤖 Generated with Claude Code
https://claude.ai/code/session_01Bwp5QefjsjMFeq6CK6cT6w