Skip to content

CMC: Add plot option to ComparisonParams - #244

Merged
cfs-data merged 4 commits into
mainfrom
cmc-add-plot-option
Aug 26, 2026
Merged

cfs-data merged 4 commits into
mainfrom
cmc-add-plot-option

Conversation

@cfs-data

Copy link
Copy Markdown
Collaborator

No description provided.

@cfs-data
cfs-data requested a review from vergep August 26, 2026 09:04

@vergep vergep left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small comments

Comment thread scripts/convert_scores.py
Comment thread src/processors/schemas.py
@github-actions

Copy link
Copy Markdown

Diff Coverage

Diff: origin/main..HEAD, staged and unstaged changes

  • packages/scratch-core/src/conversion/exceptions.py (100%)
  • packages/scratch-core/src/conversion/surface_comparison/models.py (100%)
  • packages/scratch-core/src/conversion/surface_comparison/pipeline.py (100%)
  • packages/scratch-core/src/conversion/surface_comparison/utils.py (100%)
  • src/processors/router.py (100%)
  • src/processors/schemas.py (100%)

Summary

  • Total: 23 lines
  • Missing: 0 lines
  • Coverage: 100%

@github-actions

Copy link
Copy Markdown

Code Coverage

Package Line Rate Branch Rate Health
. 96% 92%
computations 93% 70%
container_models 99% 100%
conversion 95% 88%
conversion.export 99% 90%
conversion.filter 97% 89%
conversion.likelihood_ratio 97% 86%
conversion.preprocess_impression 97% 86%
conversion.preprocess_striation 90% 62%
conversion.profile_correlator 96% 81%
conversion.surface_comparison 98% 86%
conversion.surface_comparison.cell_registration 98% 89%
conversion.surface_comparison.cmc_consensus 100% 100%
extractors 97% 75%
mutations 100% 100%
parsers 97% 50%
parsers.patches 89% 60%
plots 98% 91%
plots.comparison 100% 100%
plots.likelihood_ratio 100% 100%
preprocessors 98% 83%
processors 98% 75%
renders 99% 50%
utils 92% 100%
Summary 98% (3774 / 3869) 87% (458 / 528)

Minimum allowed line rate is 50%

@cfs-data
cfs-data merged commit fd4f4ff into main Aug 26, 2026
4 checks passed
@cfs-data
cfs-data deleted the cmc-add-plot-option branch August 26, 2026 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants